Change release trigger from main push to tags by phillipc · Pull Request #280 · knockout/tko

phillipc · 2026-04-05T19:00:52Z

@brianmhunt: Only on tagging not no any push to main?

Summary by CodeRabbit

Chores
- Release workflow now triggers on version tags (v*) instead of pushes to the main branch for clearer release control.
- Added a validation step that verifies the tag’s version exactly matches the computed release version, preventing mismatched releases.

@brianmhunt

@brianmhunt: Only on tagging not no any push to main?

coderabbitai · 2026-04-05T19:01:07Z

Warning

Rate limit exceeded

@brianmhunt has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 46 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 46 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fb0b301-018f-423e-8a1e-ca2d9c3283ea

📥 Commits

Reviewing files that changed from the base of the PR and between efdeb74 and 5590e15.

📒 Files selected for processing (1)

.github/workflows/release.yml

📝 Walkthrough

Walkthrough

Changed the release workflow trigger from pushes to main to pushes of tags matching v*, and added a publish-job validation step that strips a leading v from github.ref_name and fails if it does not exactly match the computed release version.

Changes

Cohort / File(s)	Summary
Release workflow `.github/workflows/release.yml`	Switched trigger from `push` on `main` to `push` on tags `v*`; updated header comment; added a `publish` job validation step that extracts tag version (strips leading `v`) and compares it to `steps.version.outputs.version`, failing if they differ.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

release: validate tag version before publish #286: Adds the same tag-version validation (strips leading v and compares pushed tag to computed release version) in the release workflow.
release: automate GitHub releases #278: Implements release-version determination and exposes it for downstream release/publish steps used by this validation.

Suggested reviewers

brianmhunt

Poem

🐰 Hopped on tags, not main today,

I strip the v and make sure they play.
If versions match, the publish sings,
If not, I stop—no broken wings.
A rabbit's check, precise and bright.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Change release trigger from main push to tags' directly and clearly summarizes the main change in the pull request—updating the workflow trigger mechanism from pushing to main to tagging.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch pc/release_tagging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/release.yml:
- Around line 15-16: The workflow currently triggers on tags matching 'v*' but
does not verify the tag equals the package version; add a validation step before
the step that runs "changeset publish" to extract the pushed tag (strip the
leading "v"), read the version from package.json (e.g., via node or npm),
compare them, and fail the job with a clear message if they differ so
accidental/mistagged tags cannot trigger a publish. Ensure the step runs after
checkout and before the publish step and references the existing tag trigger
('v*') and the "changeset publish" step so it's executed in the correct place.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e90a5c9a-403c-4618-b48e-7bded68d9b35

📥 Commits

Reviewing files that changed from the base of the PR and between b761bf2 and efdeb74.

📒 Files selected for processing (1)

.github/workflows/release.yml

.github/workflows/release.yml

release: validate tag version before publish

brianmhunt · 2026-04-06T11:23:36Z

Great catch, ty @phillipc . I added an additional check here for version-tag mismatch.

brianmhunt · 2026-04-06T11:33:56Z

@phillipc thanks for merging :) I was going to wait for the coderabbit review "just in case" I think it's good.

Noting we can also tag coderabbit for review like this:

@coderabbitai please re-review

coderabbitai · 2026-04-06T11:34:09Z

@brianmhunt Sure! I'll kick off a fresh review of PR #280 right away.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Change release trigger from main push to tags

efdeb74

@brianmhunt: Only on tagging not no any push to main?

coderabbitai bot reviewed Apr 5, 2026

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

brianmhunt added 2 commits April 6, 2026 07:13

release: validate tag version before publish

1561279

Merge pull request #286 from knockout/bmh/sc-release-tag-version-check

4d6dd51

release: validate tag version before publish

Merge branch 'main' into pc/release_tagging

5590e15

phillipc merged commit 21e6039 into main Apr 6, 2026
7 of 8 checks passed

phillipc deleted the pc/release_tagging branch April 6, 2026 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change release trigger from main push to tags#280

Change release trigger from main push to tags#280
phillipc merged 4 commits intomainfrom
pc/release_tagging

phillipc commented Apr 5, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 5, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

brianmhunt commented Apr 6, 2026

Uh oh!

Uh oh!

brianmhunt commented Apr 6, 2026

Uh oh!

coderabbitai bot commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

phillipc commented Apr 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brianmhunt commented Apr 6, 2026

Uh oh!

Uh oh!

brianmhunt commented Apr 6, 2026

Uh oh!

coderabbitai bot commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

phillipc commented Apr 5, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 5, 2026 •

edited

Loading